Versions Compared

Old Version 1

changes.mady.by.user Pankaj Goyal

Saved on

compared with

New Version 2

changes.mady.by.user Gergely Csatari

Saved on

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.


#ItemDescriptionApproved ProcessNotes

PR WS ScopePR affecting multiple Work Stream (WS) 
  •  Not Allowed
  •  Allowed
  •  Allowed in exceptional cases 

If allowed under exceptional cases, who decides, who approves (all WSLs affected by PR?)

Gergely Csatari : We discussed that the pr should be approved by the sub-project lead of all affected sub-projects.


PR CH ScopePR affecting multiple chapters
  •  Not Allowed
  •  Allowed
  •  Allowed in exceptional cases 

Gergely Csatari : I think this should not be a problem to allow.


PR Topic ScopePR affecting multiple disjointed topics
  •  Not Allowed
  •  Allowed
  •  Allowed in exceptional cases 

Gergely Csatari : I think this should not be a problem to allow.


PR Comment ResolutionWho is authorised to "resolve" a comment
  •  Comment Author
  •  PR Author
  •  WSL if Comment Author unresponsive and WSL not PR Author
  •  Another Active Contributor if WSL is the PR Author

What is the period of unresponsiveness?

Gergely Csatari : According to CONTRIBUTING.md:

"Comments/sub-Conversations within a PR may only be marked Resolved by:

  • A) The originator of the sub-conversation.
  • B) The relevant WSL or
  • C) An automated timeout of 48hrs when there has been no additional comments after an update is posted to resolve the sub-thread.
  • The person responding to a sub-conversation shall not mark it as Resolved."

PR Change Resolution
  •  Change Author
  •  Who if Change Author unresponsive 

Gergely Csatari : Should not matter who is making corrections until the corrections are done.


Minimum duration a PR needs to be open for maximising input after changes complete
  •  1 week
  •  2 weeks
  •   

Or should it be Minor 1 week, all others at least 2 weeks?

Gergely Csatari: There is a 2 days cool off period mandated by the current CONTRIBUTING.md I do not see a reason to change it.



PR Re-Approvals Ignore approvals made prior to non-typo changes
  •  Required After non-typo changes
  •  Not required 

Gergely Csatari: Arent't these automatically cleared after a new commit is pushed?


PR Merge – non WSL author
  •  WSL


PR Merge – WSL author
  •  WSL - no additional steps
  •  Final Additional Reviewer to ensure all comments/changes addressed and processes observed
Final Additional Reviewer to comment that they are OK with the PR being merged. They would have verified that the above agreed-to processes have all been observed.